koji

#2300 query_buildroots can perform redundant joins
Closed: Fixed by tkopecek. Opened by mikem.

Closed: Fixed
Reopen Issue

This is a followup to #2299

the original optimization from #2074 leaves the original joins and clauses in place for the rpmID and archiveID cases, even though they are essentially obsoleted.

Granted, we do need to perform the join to return the is_update field in the rpmID case (though I wonder if we actually need that field). Otoh, the join in the archiveID case seems entirely redundant.

Having the is_update field only when querying by rpmID is a a bit of an oddity here and it doesn't look like we rely on this anywhere. All the calls that want this are using listRPMs instead. So I think this is ok to change.

Still, it is an api change.

Metadata Update from @mikem:
- Custom field Size adjusted to None

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.22

Metadata Update from @jcupova:
- Issue tagged with: testing-ready

PR #2301

Metadata Update from @mfilip:
- Issue tagged with: testing-done

Commit 6e501202 fixes this issue

Commit b2dd73fa fixes this issue

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/2300

Please continue any further discussion there.
Metadata
None

testing-done testing-ready

None
None
Low
None
Related Pull Requests
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.